[Tracing Instrumentation] Add instrumentation in InboundHandler #10143

Gaganjuneja · 2023-09-20T17:02:01Z

Description

Add instrumentation in InboundHandler class so that it's generically available to all the actions.

Related Issues

Resolves #10095

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gaganjuneja · 2023-09-20T17:05:08Z

@reta, Please take a look. Thanks!

github-actions · 2023-09-20T17:31:43Z

Compatibility status:

Checks if related components are compatible with change f13dc76

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

github-actions · 2023-09-20T17:48:34Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/25922/
CommitID: 777421c
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/transport/InboundHandler.java

server/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableTransportChannel.java

github-actions · 2023-10-04T18:28:46Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/26942/
CommitID: 438f66a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

server/src/main/java/org/opensearch/transport/RequestHandlerRegistry.java

server/src/main/java/org/opensearch/transport/TcpTransportChannel.java

...er/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableTcpTransportChannel.java

github-actions · 2023-10-04T19:54:10Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/26951/
CommitID: 6b3c132

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

...er/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableTcpTransportChannel.java

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

github-actions · 2023-10-04T22:14:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/26993/
CommitID: e8b0339
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-04T22:53:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/26997/
CommitID: f13dc76

* Add instrumentation in InboundHandler Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> (cherry picked from commit aac0f09) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

peternied · 2023-10-05T02:29:26Z

FYI @Gaganjuneja & @reta This is a breaking change impacting the security plugin and performance-analyzer. Can you help mitigate the build failures associated with this change?

Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

[Build Break] Breaking changes from Add instrumentation in InboundHandler #10143 security#3462

reta · 2023-10-05T02:44:08Z

@peternied absolutely, I will take care of it tomorrow morning, thank you

…) (#10381) * Add instrumentation in InboundHandler * Add CHANGELOG * Address review comment * Address review comment * Address review comment * Empty-Commit * Address review comment * Address review comment * Address review comment --------- (cherry picked from commit aac0f09) Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>

msfroh · 2023-10-05T16:41:16Z

I ran a search for new TransportService: https://github.com/search?q=org%3Aopensearch-project+%22new+TransportService%22&type=code

~~I'll check to see if opensearch-sdk-java is okay...~~ Posted PR to fix opensearch-sdk-java: opensearch-project/opensearch-sdk-java#951

…search-project#10143) * Add instrumentation in InboundHandler Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>

…search-project#10143) * Add instrumentation in InboundHandler Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

github-actions bot added distributed framework enhancement Enhancement or improvement to existing feature or request labels Sep 20, 2023

Gaganjuneja mentioned this pull request Sep 20, 2023

[Tracing Instrumentation] Add instrumentation in transport action #10096

Open

6 tasks